[odc] Daily src changes for 2006-04-20

ODC auto at squish.net
Fri Apr 21 08:00:33 BST 2006


OpenBSD src changes summary for 2006-04-20
==========================================

distrib/sets                            games/tetris
regress/usr.bin                         sbin/dhclient
sbin/fsck_ext2fs                        sbin/ipsecctl
sbin/route                              sbin/sysctl
share/man                               sys/arch/amd64/amd64
sys/arch/hp300/dev                      sys/dev
sys/dev/ic                              sys/dev/pci
sys/dev/pcmcia                          sys/dev/usb
sys/kern                                sys/nfs
sys/scsi                                sys/sys
usr.bin/bc                              usr.bin/cvs
usr.bin/rcs                             usr.bin/ssh
usr.bin/xlint                           usr.bin/yacc
usr.sbin/dhcpd                          usr.sbin/mopd
usr.sbin/ospfd                          

== distrib =========================================================== 01/08 ==

  http://www.openbsd.org/cgi-bin/cvsweb/src/distrib

sets

  ~ lists/man/mi                          

  > sync (deraadt@)

== games ============================================================= 02/08 ==

  http://www.openbsd.org/cgi-bin/cvsweb/src/games

tetris

  ~ tetris.c                              

  > Clean up getopt stuff and use strtonum instead of atoi.
  > OK jaredy@ (ray@)

  ~ scores.c                              ~ screen.c

  > Replace magic numbers with sizeof(array).
  > OK jaredy@ (ray@)

== regress =========================================================== 03/08 ==

  http://www.openbsd.org/cgi-bin/cvsweb/src/regress

usr.bin

  ~ xlint/test-5.c.exp                    

  > Reflect new warning format (cloder@)

  ~ xlint/Makefile                        + xlint/test-17.c
  + xlint/test-17.c.exp                   

  > Test case for unreachable breaks (cloder@)

  ~ xlint/Makefile                        + xlint/test-18.c
  + xlint/test-18.c.exp                   

  > Test for (soon to be coming) LINTUSED special comment (cloder@)

  ~ rcs/Makefile                          + rcs/rlog-rflag1.out
  + rcs/rlog-rflag2.out                   + rcs/rlog-rflag3.out
  + rcs/rlog-rflag4.out                   

  > add various tests for `rlog -r' (not enabled yet); OK ray at .sa@)

== sbin ============================================================== 04/08 ==

  http://www.openbsd.org/cgi-bin/cvsweb/src/sbin

dhclient

  ~ clparse.c                             

  > adjust comments as to what keywords are legal; from fkr (deraadt@)

fsck_ext2fs

  ~ main.c                                ~ utilities.c

  > solve some signal races; from fsck_ffs; ok pedro (deraadt@)

ipsecctl

  ~ parse.y                               

  > constify char *infile here, too.  noticed by lint. (hshoexer@)

route

  ~ route.c                               

  > Instead of printing useless metrics like recvpipe and sendpipe print
  > rmx_pksent in route get. This makes it possible to identify DoS targets
  > even if you have a full routing table. OK henning@ (claudio@)

sysctl

  ~ sysctl.c                              

  > print timedelta; ok dlg (deraadt@)

== share ============================================================= 05/08 ==

  http://www.openbsd.org/cgi-bin/cvsweb/src/share

man

  ~ man4/vic.4                            

  > slightly better wording (martin@)

  ~ man4/udcf.4                           

  > kill trailing space; (jmc@)

  ~ man4/usb.4                            

  > fix SEE ALSO; (jmc@)

  ~ man9/Makefile                         + man9/rwlock.9

  > Document the rwlock() API, okay deraadt@ (pedro@)

== sys =============================================================== 06/08 ==

  http://www.openbsd.org/cgi-bin/cvsweb/src/sys

arch/amd64/amd64

  ~ mpbios_intr_fixup.c                   

  > Add a few more devices integrated on nForce4 chipsets. (kettenis@)

arch/hp300/dev

  ~ sti_sgc.c                             

  > no longer failure care; ok miod (deraadt@)

dev

  ~ ipmi.c                                

  > Fix various printf() issues: too many arguments, not enough arguments,
  > argument
  > order reversed, wrong modifiers. ok deraadt@ marco@ mickey@ (miod@)

dev/ic

  ~ ami.c                                 ~ amivar.h

  > this is the proper fix for krws bug. i feel kinda bad taking the commit
  > from him since he did most of the hard work on it.
  > when marco added the sensor for logical disks he added some extra bits
  > to the softc, but inside an #if NBIO > 0 block. NBIO is set by "bio.h"
  > which was included in ami.c, but not in ami_pci.c which is what is
  > actually responsible for getting the softc allocated. because of this
  > the softc in the rest of the system was smaller than what ami.c needed,
  > so technically it was using unallocated memory. in krws case that
  > unallocated space was filled with garbage, hence his panic.
  > the moral of this story is do NOT put #if inside structs that are passed
  > between different source files. its too easy to have this kind of screwup
  > happen. (dlg@)

  ~ ami.c                                 

  > remove some useless code found by lint. (dlg@)

  ~ ami.c                                 ~ amivar.h

  > get rid of the ccb list typedef. while here switch to TAILQ_HEAD instead
  > of TAILQ_TAIL when pulling ccbs off the free list since it does less
  > "interesting" things with pointers. changes prompted by lint bitching.
  > (dlg@)

  ~ ami.c                                 

  > return after goto wont be reached, so remove it. found by lint. (dlg@)

  ~ mfi.c                                 ~ mfivar.h

  > marco hates typedefs as much as i do, so he asked me to clean mfi like i
  > just did with ami.	this gets rid of the typedef for the ccb lists.
  > also uses TAILQ_FIRST to get ccbs off the freelist. this is a proactive
  > fix for a lint teary. (dlg@)

  ~ aic6360.c                             

  > Cast unsigned to signed when you want to check for negative values. (miod@)

  ~ ath.c                                 ~ mpt_openbsd.c

  > printf() calls with the format string spanning several lines should not
  > have
  > trailing commas between string chunks, for this has unexpected effects.
  > (miod@)

  ~ aac.c                                 ~ am7990.c
  ~ if_wi_hostap.c                        ~ isp.c
  ~ mfi.c                                 ~ rt2560.c
  ~ rt2661.c                              ~ rtl81x9.c

  > Fix various printf() issues: too many arguments, not enough arguments,
  > argument
  > order reversed, wrong modifiers. ok deraadt@ marco@ mickey@ (miod@)

dev/pci

  ~ pcscp.c                               

  > ANSI function declarations
  > prompted by brad@ (martin@)

  ~ gtp.c                                 

  > Make these compile again. (miod@)

  ~ auich.c                               ~ if_epic_pci.c
  ~ if_ixgb.c                             ~ if_pcn.c
  ~ if_san_xilinx.c                       ~ if_sandrv.c
  ~ if_sk.c                               ~ ises.c
  ~ siop_pci_common.c                     

  > Fix various printf() issues: too many arguments, not enough arguments,
  > argument
  > order reversed, wrong modifiers. ok deraadt@ marco@ mickey@ (miod@)

dev/pcmcia

  ~ pcmciadevs.h                          

  > regen (brad@)

  ~ pcmciadevs                            

  > add the Belkin F5D6020 802.11b WLAN card. (brad@)

  ~ esp_pcmcia.c                          

  > Make these compile again. (miod@)

  ~ aic_pcmcia.c                          ~ com_pcmcia.c
  ~ if_sm_pcmcia.c                        ~ if_wi_pcmcia.c
  ~ wdc_pcmcia.c                          

  > Fix various printf() issues: too many arguments, not enough arguments,
  > argument
  > order reversed, wrong modifiers. ok deraadt@ marco@ mickey@ (miod@)

dev/usb

  ~ files.usb                             ~ udcf.c

  > - remove the 'needs-flag' from the udcf entry in files.usb and the #ifdef
  > NUDCF
  > idom in udcf.c
  > - declare t1 to t7 as static to prevent the risk of name clashes
  > - add two missing function prototypes
  > help and ok miod@ (mbalmer@)

  ~ udcf.c                                

  > open/close/cdevsw code goes bye bye; ok mbalber (deraadt@)

kern

  ~ kern_rwlock.c                         

  > much -> must (pedro@)

nfs

  ~ nfs_bio.c                             ~ nfs_vnops.c

  > Remove unused debug code that sneaked in by accident long ago (pedro@)

scsi

  ~ scsi_ioctl.c                          ~ ses.c

  > Fix various printf() issues: too many arguments, not enough arguments,
  > argument
  > order reversed, wrong modifiers. ok deraadt@ marco@ mickey@ (miod@)

sys

  ~ sensors.h                             

  > add SENSOR_TIMEDELTA sensor; ok dlg (deraadt@)

== usr.bin =========================================================== 07/08 ==

  http://www.openbsd.org/cgi-bin/cvsweb/src/usr.bin

bc

  ~ bc.y                                  

  > unused variable (deraadt@)

cvs

  ~ log.c                                 ~ log.h

  > change cvs_log() and cvs_vlog() return type to void; OK niallo at .sa@)

rcs

  ~ rcs.1                                 

  > add a compatibility note; suggested by and ok xsa (jmc@)

  ~ rcs.1                                 

  > reinstate HISTORY, from cvsintro(7)...
  > suggested by xsa (jmc@)

  ~ rcs.1                                 

  > remove an unneeded macro; (jmc@)

ssh

  ~ kex.h                                 ~ dispatch.h
  ~ dispatch.c                            ~ clientloop.c
  ~ auth.h                                

  > replace the last non-sig_atomic_t flag used in a signal handler with a
  > sig_atomic_t, unfortunately with some knock-on effects in other (non-
  > signal) contexts in which it is used; ok markus@ (djm@)

  ~ sshconnect.c                          

  > simplify; ok djm@ (markus@)

  ~ includes.h                            ~ session.c
  ~ sftp.c                                

  > Switch from using pipes to socketpairs for communication between
  > sftp/scp and ssh, and between sshd and its subprocesses. This saves
  > a file descriptor per session and apparently makes userland ppp over
  > ssh work; ok markus@ deraadt@ (djm@)

xlint

  ~ lint1/func.c                          

  > Do not warn about unreachable breaks in a switch. Prodded by theo, and
  > this is necessitated by output of lex (thanks a lot). (cloder@)

  ~ lint1/cgram.y                         ~ lint1/externs1.h
  ~ lint1/func.c                          ~ lint1/scan.l

  > Add a LINTUSED special comment which marks the following declared symbol(s)
  > as used so that lint2 doesn't complain. Prodded by deraadt (cloder@)

yacc

  ~ skeleton.c                            

  > yydebug has to always be there, even if it is not used.  this pleases
  > lint on every program that has a .y in it....; ok cloder though he does
  > not understand yet (deraadt@)

  ~ reader.c                              

  > Fix off-by-one read caused by bad grammars. I think this defect was
  > present in the very first version of byacc from the early 90's and was
  > only triggered recently when I used malloc.conf -> JG on a bad gramamr.
  > OK millert@ (cloder@)

  ~ skeleton.c                            

  > use new LINTED keyword for a global which is perhaps not used, but must
  > be there; ok cloder (deraadt@)

== usr.sbin ========================================================== 08/08 ==

  http://www.openbsd.org/cgi-bin/cvsweb/src/usr.sbin

dhcpd

  ~ conflex.c                             

  > list must be sorted (deraadt@)

mopd

  ~ common/file.c                         ~ common/pf.c
  ~ common/print.c                        

  > More delint. -moj (maja@)

ospfd

  ~ ospfd.h                               ~ parse.y

  > Simplify the defaults handling. This is long overdue and necessary to add
  > auth-type et al. to the main and area blocks. OK norby@ (claudio@)

===============================================================================



More information about the odc mailing list