[odc] Daily src changes for 2008-03-15
ODC
auto at squish.net
Sun Mar 16 07:00:01 GMT 2008
OpenBSD src changes summary for 2008-03-15
==========================================
distrib/miniroot gnu/usr.bin/perl
kerberosV lib/libc
libexec/ftpd libexec/login_skey
libexec/login_tis libexec/tftp-proxy
libexec/tftpd regress/sys
sbin/isakmpd sbin/mount_portal
sbin/pflogd sbin/ping6
share/man sys/arch/sparc/dev
sys/arch/sparc/sparc sys/arch/sparc64/include
sys/arch/sparc64/sparc64 sys/dev/sbus
sys/kern sys/netinet
usr.bin/ssh usr.sbin/bgpd
usr.sbin/bind usr.sbin/ospf6d
usr.sbin/ospfd usr.sbin/pcidump
usr.sbin/ppp usr.sbin/relayd
usr.sbin/ripd usr.sbin/route6d
usr.sbin/sensorsd usr.sbin/snmpd
usr.sbin/syslogd usr.sbin/tcpdump
usr.sbin/traceroute6
== distrib =========================================================== 01/11 ==
http://www.openbsd.org/cgi-bin/cvsweb/src/distrib
miniroot
~ install.sub
> When installing via NFS, only retry the mount five times (instead of the
> default 10,000 times).
> ok deraadt@ krw@ thib@ (jsing@)
== gnu =============================================================== 02/11 ==
http://www.openbsd.org/cgi-bin/cvsweb/src/gnu
usr.bin/perl
~ perl.c
> This should set msg_control using CMSG_SIZE(), and not assume that
> sizeof(buffer) is the right size (alignments can mess it up). Code is
> apparently not used, but it is better if all examples show the correct
> idiom
> ok hshoexer (deraadt@)
== kerberosV ========================================================= 03/11 ==
http://www.openbsd.org/cgi-bin/cvsweb/src/kerberosV
kerberosV
~ src/kcm/connect.c
> seperate out space vs len calculations; ok hshoexer (deraadt@)
== lib =============================================================== 04/11 ==
http://www.openbsd.org/cgi-bin/cvsweb/src/lib
libc
~ gen/auth_subr.c
> Repair the simple cases for msg_controllen where it should just be
> CMSG_SIZE(sizeof(int)), not sizeof(buffer) which may be larger because
> of alignment; ok kettenis hshoexer (deraadt@)
~ string/memset.c
> Convert c to unsigned char, like it says in the manual. Also add
> cast to make it explicit.
> Found by lint, OK millert. (ray@)
~ string/swab.c
> - len is size_t, but n uses len and is an int. Matching those types
> should be good, plus it prevents weird things from happening if
> len > INT_MAX.
> - Since n is now size_t, compare it against 0 instead of >= 0.
> - temp is used to store individual bytes, so use char instead
> (matches fp and tp).
> - millert noted that the comma operator may not guarantee order of
> execution, so replace with semicolons.
> Found by lint, OK millert. (ray@)
== libexec =========================================================== 05/11 ==
http://www.openbsd.org/cgi-bin/cvsweb/src/libexec
ftpd
~ monitor_fdpass.c
> Repair the simple cases for msg_controllen where it should just be
> CMSG_SIZE(sizeof(int)), not sizeof(buffer) which may be larger because
> of alignment; ok kettenis hshoexer (deraadt@)
login_skey
~ login_skey.c
> Repair the simple cases for msg_controllen where it should just be
> CMSG_SIZE(sizeof(int)), not sizeof(buffer) which may be larger because
> of alignment; ok kettenis hshoexer (deraadt@)
login_tis
~ login_tis.c
> Repair the simple cases for msg_controllen where it should just be
> CMSG_SIZE(sizeof(int)), not sizeof(buffer) which may be larger because
> of alignment; ok kettenis hshoexer (deraadt@)
tftp-proxy
~ tftp-proxy.c
> Repair more msg_controllen dealing with structures or arrays of
> descriptors; ok hshoexer, also looked at by kettenis and henning (deraadt@)
tftpd
~ tftpd.c
> Repair more msg_controllen dealing with structures or arrays of
> descriptors; ok hshoexer, also looked at by kettenis and henning (deraadt@)
== regress =========================================================== 06/11 ==
http://www.openbsd.org/cgi-bin/cvsweb/src/regress
sys
~ kern/unfdpass/expected ~ kern/unfdpass/unfdpass.c
> Repair usage of CMSG_SPACE and CMSG_LEN. While there, send three fds
> instead of just two as this decreases the propability that things just
> work although the sizes are wrong (ie. 8 aligns correctly on both 32 and 64
> bit
> platforms even with wrong usage of CMSG_{LEN,SPACE} whereas 12 doesn't).
> (hshoexer@)
== sbin ============================================================== 07/11 ==
http://www.openbsd.org/cgi-bin/cvsweb/src/sbin
isakmpd
~ monitor_fdpass.c
> Repair the simple cases for msg_controllen where it should just be
> CMSG_SIZE(sizeof(int)), not sizeof(buffer) which may be larger because
> of alignment; ok kettenis hshoexer (deraadt@)
mount_portal
~ activate.c
> Repair the simple cases for msg_controllen where it should just be
> CMSG_SIZE(sizeof(int)), not sizeof(buffer) which may be larger because
> of alignment; ok kettenis hshoexer (deraadt@)
pflogd
~ privsep_fdpass.c
> Repair the simple cases for msg_controllen where it should just be
> CMSG_SIZE(sizeof(int)), not sizeof(buffer) which may be larger because
> of alignment; ok kettenis hshoexer (deraadt@)
ping6
~ ping6.c
> Fix several CMSG-related bugs. Chaining CMSG's is tricky since you need to
> use CMSG_SPACE for all except the last one, which should be CMSG_LEN. This
> makes calculate .msg_controllen tricky. Also make sure that we can receive
> multiple CMSG's again.
> ok deraadt@, hshoexer@ (kettenis@)
== share ============================================================= 08/11 ==
http://www.openbsd.org/cgi-bin/cvsweb/src/share
man
~ man4/man4.sparc/tvtwo.4 ~ man4/man4.sparc64/tvtwo.4
> Document video modes. (miod@)
~ man3/CMSG_DATA.3
> show the correct idiom (deraadt@)
~ man4/man4.sparc/tvtwo.4 ~ man4/man4.sparc64/tvtwo.4
> tweak previous; (jmc@)
== sys =============================================================== 09/11 ==
http://www.openbsd.org/cgi-bin/cvsweb/src/sys
arch/sparc/dev
~ tvtwo.c
> Support the old-prom XVideo boards by rewriting the sbus range registers;
> tested by Thorsten Glaser <tg at mirbsd.de> on sparc; while there, pretty and
> shrink dmesg output. (miod@)
arch/sparc/sparc
~ locore.s
> After 15 years of fun, fix Torek's ovbcopy() operation when copying shorts
> backwards. (miod@)
arch/sparc64/include
~ cpu.h
> Make GENERIC.MP work on the e10k. The e10k is a bit funky since UPA only
> supports 32 ports, and a machine with up to 64 CPUs obviously needs more.
> So the machine has a special ASIC that does port translation, and because
> of that we need to distinguish between port ID's and interrupt target ID's.
> (kettenis@)
arch/sparc64/sparc64
~ cpu.c ~ ipifuncs.c
~ pmap.c ~ vm_machdep.c
> Make GENERIC.MP work on the e10k. The e10k is a bit funky since UPA only
> supports 32 ports, and a machine with up to 64 CPUs obviously needs more.
> So the machine has a special ASIC that does port translation, and because
> of that we need to distinguish between port ID's and interrupt target ID's.
> (kettenis@)
dev/sbus
~ tvtwo.c
> Support the old-prom XVideo boards by rewriting the sbus range registers;
> tested by Thorsten Glaser <tg at mirbsd.de> on sparc; while there, pretty and
> shrink dmesg output. (miod@)
kern
~ kern_clock.c
> In statclock(), fix local index type in the profiling code. Avoids
> out-of-bounds array accesses on some platforms. (miod@)
netinet
~ ip_id.c
> Because the ip_id code initialisation is a specific case of shuffling
> a set of incrementing integers (and not an arbitrary set of values) it
> is possible to populate the array as we shuffle it in a single forward
> pass. Clever optimisation from didickman AT gmail.com;
> ok deraadt@ mcbride@ (djm@)
~ ip_id.c
> off by one at end of array (djm@)
~ ip_id.c
> revert - I'm a dumbfuck who doesn't know his own API (djm@)
== usr.bin =========================================================== 10/11 ==
http://www.openbsd.org/cgi-bin/cvsweb/src/usr.bin
ssh
~ monitor_fdpass.c
> Repair the simple cases for msg_controllen where it should just be
> CMSG_SIZE(sizeof(int)), not sizeof(buffer) which may be larger because
> of alignment; ok kettenis hshoexer (deraadt@)
== usr.sbin ========================================================== 11/11 ==
http://www.openbsd.org/cgi-bin/cvsweb/src/usr.sbin
bgpd
~ buffer.c
> Repair the simple cases for msg_controllen where it should just be
> CMSG_SIZE(sizeof(int)), not sizeof(buffer) which may be larger because
> of alignment; ok kettenis hshoexer (deraadt@)
~ imsg.c
> Repair more msg_controllen dealing with structures or arrays of
> descriptors; ok hshoexer, also looked at by kettenis and henning (deraadt@)
bind
~ lib/isc/shuffle.c
> Because the shuffle code initialisation is a specific case of shuffling
> a set of incrementing integers (and not an arbitrary set of values) it
> is possible to populate the array as we shuffle it in a single forward
> pass. Clever optimisation from didickman AT gmail.com;
> ok deraadt@ mcbride@
> (same change as netinet/ip_id.c) (djm@)
~ lib/isc/unix/privsep_fdpass.c
> Repair the simple cases for msg_controllen where it should just be
> CMSG_SIZE(sizeof(int)), not sizeof(buffer) which may be larger because
> of alignment; ok kettenis hshoexer (deraadt@)
ospf6d
~ packet.c
> Repair more msg_controllen dealing with structures or arrays of
> descriptors; ok hshoexer, also looked at by kettenis and henning (deraadt@)
ospfd
~ packet.c
> Repair more msg_controllen dealing with structures or arrays of
> descriptors; ok hshoexer, also looked at by kettenis and henning (deraadt@)
pcidump
~ pcidump.c
> if the device supports the PCI capabilities list and the verbose flag
> is specified, print all PCI capabilities by name instead of just the
> initial capabilities pointer.
> ok dlg@ kettenis@ (reyk@)
ppp
~ ppp/bundle.c
> Repair more msg_controllen dealing with structures or arrays of
> descriptors; ok hshoexer, also looked at by kettenis and henning (deraadt@)
relayd
~ buffer.c
> Repair the simple cases for msg_controllen where it should just be
> CMSG_SIZE(sizeof(int)), not sizeof(buffer) which may be larger because
> of alignment; ok kettenis hshoexer (deraadt@)
~ imsg.c
> Repair more msg_controllen dealing with structures or arrays of
> descriptors; ok hshoexer, also looked at by kettenis and henning (deraadt@)
ripd
~ packet.c
> Repair more msg_controllen dealing with structures or arrays of
> descriptors; ok hshoexer, also looked at by kettenis and henning (deraadt@)
route6d
~ route6d.c
> repair msg_controllen and also an errant buf[CMSG_LEN(..)] decl (deraadt@)
sensorsd
~ sensorsd.c ~ sensorsd.conf.5
> explicitly report whether the lower or upper limit is exceeded; ok sthen@
> ckuethe@ (cnst@)
snmpd
~ mib.c
> move zerodotzero up so more stuff can use it
> this is an ok bit of a bigger diff that reyk wanted split up (dlg@)
~ buffer.c ~ imsg.c
> Repair the simple cases for msg_controllen where it should just be
> CMSG_SIZE(sizeof(int)), not sizeof(buffer) which may be larger because
> of alignment; ok kettenis hshoexer (deraadt@)
~ mib.c
> provide sizeofa for counting the number of elements in an array. use it for
> passing the length of the mib in all these sysctl calls.
> ok reyk@ (dlg@)
syslogd
~ privsep_fdpass.c
> Repair the simple cases for msg_controllen where it should just be
> CMSG_SIZE(sizeof(int)), not sizeof(buffer) which may be larger because
> of alignment; ok kettenis hshoexer (deraadt@)
tcpdump
~ privsep_fdpass.c
> Repair the simple cases for msg_controllen where it should just be
> CMSG_SIZE(sizeof(int)), not sizeof(buffer) which may be larger because
> of alignment; ok kettenis hshoexer (deraadt@)
traceroute6
~ traceroute6.c
> space allocated is sum of CMSG_SPACE()'s. length given to the kernel
> is the sum of all the CMSG_SPACE()'s, except for the last element use
> CMSG_LEN(). Insane, right?
> ok kettenis hshoexer (deraadt@)
===============================================================================
More information about the odc
mailing list